Bobby/stock_system
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Add None checks to Position class property methods

Browse Source
This commit is contained in:
Bobby (aider) 2025-02-13 08:07:52 -08:00
parent 3a962fb685
commit 0cb11574a3
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/trading/portfolio.py
View File

@ -14,21 +14,30 @@ class Position:
@property
def current_value(self) -> float:
# TODO: Implement real-time price fetching
if self.entry_price is None or self.shares is None:
return 0.0
return self.shares * self.entry_price
@property
def potential_profit(self) -> float:
"""Calculate potential profit at target price"""
if self.target_price is None or self.entry_price is None or self.shares is None:
return 0.0
return (self.target_price - self.entry_price) * self.shares
@property
def potential_loss(self) -> float:
"""Calculate potential loss at stop loss"""
if self.stop_loss is None or self.entry_price is None or self.shares is None:
return 0.0
return (self.stop_loss - self.entry_price) * self.shares
@property
def risk_reward_ratio(self) -> float:
"""Calculate risk/reward ratio"""
if (self.target_price is None or self.entry_price is None or
self.stop_loss is None):
return 0.0
potential_gain = self.target_price - self.entry_price
potential_risk = self.entry_price - self.stop_loss
return abs(potential_gain / potential_risk) if potential_risk != 0 else 0