From 94671119f29ad0f3ecb63a63b4a877dce64806d0 Mon Sep 17 00:00:00 2001 From: "Bobby (aider)" Date: Thu, 13 Feb 2025 09:14:27 -0800 Subject: [PATCH] feat: Replace time_input with text_input for time entry validation --- src/pages/journal/trading_journal_page.py | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/pages/journal/trading_journal_page.py b/src/pages/journal/trading_journal_page.py index 72b60da..c50d1dc 100644 --- a/src/pages/journal/trading_journal_page.py +++ b/src/pages/journal/trading_journal_page.py @@ -238,7 +238,12 @@ def trading_journal_page(): order_type = st.selectbox("Order Type", ["Market", "Limit"], key="add_trade_order_type") entry_date = st.date_input("Entry Date") - entry_time = st.time_input("Entry Time") + entry_time_str = st.text_input("Entry Time (HH:MM)", "09:30") + try: + entry_time = datetime.strptime(entry_time_str, "%H:%M").time() + except ValueError: + st.error("Please enter time in HH:MM format (e.g. 09:30)") + st.stop() if direction == "Buy": followed_rules = st.checkbox("Followed Trading Rules") @@ -307,11 +312,16 @@ def trading_journal_page(): value=trade['entry_date'].date(), key="update_entry_date" ) - entry_time = st.time_input( - "Entry Time", - value=trade['entry_date'].time(), + entry_time_str = st.text_input( + "Entry Time (HH:MM)", + value=trade['entry_date'].strftime("%H:%M"), key="update_entry_time" ) + try: + entry_time = datetime.strptime(entry_time_str, "%H:%M").time() + except ValueError: + st.error("Please enter time in HH:MM format (e.g. 09:30)") + st.stop() new_notes = st.text_area("Notes", value=trade['notes'] if trade['notes'] else "",