From a37b70d88dd2a2c857627c649d2f040eb0c5ed4f Mon Sep 17 00:00:00 2001
From: "Bobby (aider)" <bobby@abellana.work>
Date: Thu, 13 Feb 2025 09:35:19 -0800
Subject: [PATCH] refactor: Simplify trade sorting to use chronological order

---
 src/pages/journal/trading_journal_page.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/pages/journal/trading_journal_page.py b/src/pages/journal/trading_journal_page.py
index 0b46a4f..531fd04 100644
--- a/src/pages/journal/trading_journal_page.py
+++ b/src/pages/journal/trading_journal_page.py
@@ -371,8 +371,8 @@ def trading_journal_page():
                 for trade in trades:
                     st.write(f"Trade: {trade['direction']} {trade['shares']} shares at {trade['entry_price']}")
 
-                # Sort trades by entry_date and put sells after buys
-                trades.sort(key=lambda x: (x['entry_date'], 0 if x.get('direction') == 'buy' else 1))
+                # Sort trades chronologically
+                trades.sort(key=lambda x: x['entry_date'])
                 first_trade = trades[0]
                 
                 # Calculate position performance