Bobby/stock_system
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Update SQL queries to use parameterized queries in trading_plan.py

Browse Source
This commit is contained in:
Bobby (aider) 2025-02-11 19:12:14 -08:00
parent 85d7638ef4
commit a47cd3e1cc
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/trading/trading_plan.py
View File

@ -329,12 +329,15 @@ def link_trades_to_plan(plan_id: int, trade_ids: List[int]) -> bool:
try: try:
# Update trades to link them to the plan # Update trades to link them to the plan
trade_ids_str = ", ".join(map(str, trade_ids)) trade_ids_str = ", ".join(map(str, trade_ids))
query = f""" query = """
ALTER TABLE stock_db.trades ALTER TABLE stock_db.trades
UPDATE plan_id = {plan_id} UPDATE plan_id = %(plan_id)s
WHERE id IN ({trade_ids_str}) WHERE id IN (%(trade_ids)s)
""" """
client.command(query) client.command(query, {
'plan_id': plan_id,
'trade_ids': trade_ids_str
})
return True return True
except Exception as e: except Exception as e:
print(f"Error linking trades to plan: {e}") print(f"Error linking trades to plan: {e}")
@ -343,13 +346,13 @@ def link_trades_to_plan(plan_id: int, trade_ids: List[int]) -> bool:
def get_plan_trades(plan_id: int) -> List[dict]: def get_plan_trades(plan_id: int) -> List[dict]:
"""Get all trades associated with a trading plan""" """Get all trades associated with a trading plan"""
with create_client() as client: with create_client() as client:
query = f""" query = """
SELECT * SELECT *
FROM stock_db.trades FROM stock_db.trades
WHERE plan_id = {plan_id} WHERE plan_id = %(plan_id)s
ORDER BY entry_date DESC ORDER BY entry_date DESC
""" """
result = client.query(query) result = client.query(query, {'plan_id': plan_id})
return [dict(zip( return [dict(zip(
['id', 'position_id', 'ticker', 'entry_date', 'shares', 'entry_price', ['id', 'position_id', 'ticker', 'entry_date', 'shares', 'entry_price',
'target_price', 'stop_loss', 'strategy', 'order_type', 'direction', 'target_price', 'stop_loss', 'strategy', 'order_type', 'direction',