Bobby/stock_system
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Correct logic in check_atr_ema_buy_condition to use previous price

Browse Source
This commit is contained in:
Bobby (aider) 2025-02-08 07:55:13 -08:00
parent b1d86d988a
commit bb3d67ead9
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/screener/t_atr_ema.py
View File

@ -11,6 +11,7 @@ def check_atr_ema_bullish_signal(df: pd.DataFrame) -> bool:
"""Check for bullish signal based on ATR EMA indicator""" """Check for bullish signal based on ATR EMA indicator"""
# Get latest values from DataFrame # Get latest values from DataFrame
last_price = df.iloc[-1] last_price = df.iloc[-1]
previous_price = df.iloc[-2] # Get the previous row for comparison
indicator = ThreeATREMAIndicator() indicator = ThreeATREMAIndicator()
results = indicator.calculate(df) results = indicator.calculate(df)
indicator = ThreeATREMAIndicator() indicator = ThreeATREMAIndicator()
@ -35,8 +36,8 @@ def check_atr_ema_buy_condition(df: pd.DataFrame) -> bool:
return ( return (
last_price['close'] < ema and last_price['close'] < ema and
last_price['close'].shift(1) <= lower_band and previous_price['close'] <= lower_band and
last_price['close'] > last_price['close'].shift(1) last_price['close'] > previous_price['close']
) )
def run_atr_ema_scanner(min_price: float, max_price: float, min_volume: int, portfolio_size: float = None) -> None: def run_atr_ema_scanner(min_price: float, max_price: float, min_volume: int, portfolio_size: float = None) -> None: