Bobby/stock_system
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: Add functionality to unlink trades from trading plans

Browse Source
This commit is contained in:
Bobby (aider) 2025-02-11 19:16:52 -08:00
parent f3d932443e
commit bee908180c
2 changed files with 60 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
src/streamlit_app.py
View File

@ -1166,7 +1166,48 @@ def trading_plan_page():
pl = (trade['exit_price'] - trade['entry_price']) * trade['shares'] pl = (trade['exit_price'] - trade['entry_price']) * trade['shares']
st.write(f"Exit: ${trade['exit_price']:.2f}") st.write(f"Exit: ${trade['exit_price']:.2f}")
st.write(f"P/L: ${pl:.2f}") st.write(f"P/L: ${pl:.2f}")
# Add unlink button for each trade
if st.button("Unlink Trade", key=f"unlink_trade_{trade['id']}"):
try:
# Update the single trade
query = """
ALTER TABLE stock_db.trades
UPDATE plan_id = NULL
WHERE id = %(trade_id)s
"""
with create_client() as client:
client.command(query, {'trade_id': trade['id']})
# Recalculate metrics
metrics = calculate_plan_metrics(plan.id)
plan.win_rate = metrics['win_rate']
plan.average_return_per_trade = metrics['average_return']
plan.profit_factor = metrics['profit_factor']
update_trading_plan(plan)
st.success(f"Trade unlinked successfully!")
st.query_params.update(rerun=True)
except Exception as e:
st.error(f"Error unlinking trade: {str(e)}")
# Add button to unlink all trades
if st.button("Unlink All Trades", key=f"unlink_all_trades_{plan.id}"):
try:
if unlink_trades_from_plan(plan.id):
# Reset metrics
plan.win_rate = None
plan.average_return_per_trade = None
plan.profit_factor = None
update_trading_plan(plan)
st.success("All trades unlinked successfully!")
st.query_params.update(rerun=True)
else:
st.error("Error unlinking trades")
except Exception as e:
st.error(f"Error unlinking trades: {str(e)}")
# Get available trades # Get available trades
with create_client() as client: with create_client() as client:
query = """ query = """

19
src/trading/trading_plan.py
View File

@ -312,10 +312,29 @@ def get_all_trading_plans(status: Optional[PlanStatus] = None) -> List[TradingPl
print(f"Error retrieving trading plans: {e}") print(f"Error retrieving trading plans: {e}")
return [] return []
def unlink_trades_from_plan(plan_id: int) -> bool:
"""Unlink all trades from a trading plan"""
with create_client() as client:
try:
query = """
ALTER TABLE stock_db.trades
UPDATE plan_id = NULL
WHERE plan_id = %(plan_id)s
"""
client.command(query, {'plan_id': plan_id})
return True
except Exception as e:
print(f"Error unlinking trades from plan: {e}")
return False
def delete_trading_plan(plan_id: int) -> bool: def delete_trading_plan(plan_id: int) -> bool:
"""Delete a trading plan by ID""" """Delete a trading plan by ID"""
with create_client() as client: with create_client() as client:
try: try:
# First unlink all trades
unlink_trades_from_plan(plan_id)
# Then delete the plan
query = "ALTER TABLE trading_plans DELETE WHERE id = %(id)s" query = "ALTER TABLE trading_plans DELETE WHERE id = %(id)s"
client.command(query, {'id': plan_id}) client.command(query, {'id': plan_id})
return True return True